I think doing them by hand like you done is the best way to go on those blanks. I have to admit I rarely use my mill for making keyblanks and i would have done exactly the same as you on those Yales. A mills essential for many jobs, and great for long slotting, grooving jobs or shapes where it’d be difficult by hand, but I’d say shaping the bits on those keys is best done by hand the way you done them. Plus you can never do too much filing work because it makes you faster and better at it every time. Milling no matter how accurate always leaves the tool finish on the surface and something like those blanks would still need a lot of fine finishing by hand afterwards to get them how you want them.
Great job I think and it’s always great to see old fashioned files and handwork instead of the usual ’I’ll give it to my mate as he’s got a CNC machine in work…'!
BTW for what it’s worth if you do consider a mill, it’s worth going by recommendations from someone who’s got a particular one that you knows has been a good machine- 99% of the far eastern hobby machines out there now are so full of electronics and are more hassle than they’re worth. it’s common for many to go through a mother-board every year at £100 a time (over here), that’s probably $150 or so your side of the pond.